linux-kernel - Re: [PATCH] PKCS#7: fix missing break on OID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2764.1459947317@warthog.procyon.org.uk>
Date:	Wed, 06 Apr 2016 13:55:17 +0100
From:	David Howells <dhowells@...hat.com>
To:	Colin King <colin.king@...onical.com>
Cc:	dhowells@...hat.com, Herbert Xu <herbert@...dor.apana.org.au>,
	"David S . Miller" <davem@...emloft.net>,
	Tadeusz Struk <tadeusz.struk@...el.com>,
	Peter Jones <pjones@...hat.com>, linux-crypto@...r.kernel.org,
	stable@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PKCS#7: fix missing break on OID_sha224 case

Colin King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> The OID_sha224 case is missing a break and it falls through
> to the -ENOPKG error default.  Since HASH_ALGO_SHA224 seems
> to be supported, this looks like an unintentional missing break.
> 
> Fixes: 07f081fb5057 ("PKCS#7: Add OIDs for sha224, sha284 and sha512 hash algos and use them")
> Cc: <stable@...r.kernel.org> # 4.2+
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: David Howells <dhowells@...hat.com>