linux-kernel - Re: [PATCH] Revert "netpoll: Fix extra refcount release in netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57051999.3080209@sandisk.com>
Date:	Wed, 6 Apr 2016 07:13:45 -0700
From:	Bart Van Assche <bart.vanassche@...disk.com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>,
	"David S. Miller" <davem@...emloft.net>
CC:	Neil Horman <nhorman@...hat.com>,
	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Alexander Duyck <aduyck@...antis.com>
Subject: Re: [PATCH] Revert "netpoll: Fix extra refcount release in
 netpoll_cleanup()"

On 04/05/16 13:58, Bjorn Helgaas wrote:
> This reverts commit 543e3a8da5a4c453e992d5351ef405d5e32f27d7.
>
> Direct callers of __netpoll_setup() depend on it to set np->dev,
> so we can't simply move that assignment up to netpoll_stup().
>
> Reported-by: Bart Van Assche <bart.vanassche@...disk.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

Tested-by: Bart Van Assche <bart.vanassche@...disk.com>

Thanks!

Bart.