linux-kernel - Re: [PATCH] usb: f_mass_storage: test whether thread is running before starting another

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1604061102050.2242-100000@iolanthe.rowland.org>
Date:	Wed, 6 Apr 2016 11:05:52 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Michal Nazarewicz <mina86@...a86.com>
cc:	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	Tony Lindgren <tony@...mide.com>,
	<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	Felipe Balbi <felipe.balbi@...ux.intel.com>,
	Bin Liu <b-liu@...com>, <pali.rohar@...il.com>
Subject: Re: [PATCH] usb: f_mass_storage: test whether thread is running
 before starting another

On Wed, 6 Apr 2016, Michal Nazarewicz wrote:

> On Tue, Apr 05 2016, Alan Stern wrote:
> > Suppose one usb_function is carrying out an I/O operation while
> > another one in the same config gets a Set-Interface request from the
> > host.
> 
> That cannot happen.  A single instance of mass_storage cannot¹ be added
> twice to the same configuration.
> 
> ¹ To be more precise, not via configfs.  A legacy gadget could do that,
>   but that would be a bug in that legacy driver, not f_mass_storage.
>   Moreover, no current legacy gadgets do that though so IMO this is an
>   academic discussion.

Okay.  Then I suggest adding this explanation to the patch description.

BTW, is configfs capable of adding a single instance twice in different 
configs?  Or is that again something only legacy gadgets can do?

Alan Stern