linux-kernel - Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN add ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcbyi7O+OWXF=CG0FMdZxoq4YWdDmA+7x3HiZf48weKLOQ@mail.gmail.com>
Date:	Wed, 6 Apr 2016 13:27:32 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	netdev <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	kernel <kernel@...oirfairelinux.com>,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew@...n.ch>, Jiri Pirko <jiri@...nulli.us>,
	Scott Feldman <sfeldma@...il.com>
Subject: Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN
 add ops

2016-04-06 8:55 GMT-07:00 Vivien Didelot <vivien.didelot@...oirfairelinux.com>:
> Neither the DSA layer nor the bridge code (see br_set_state) really care
> about eventual errors from STP state setters, so make it void.
>
> The DSA layer separates the prepare and commit phases of switchdev in
> two different functions. Logical errors must not happen in commit
> routines, so make them void.
>
> Changes v1 -> v2:
>   - rename port_stp_update to port_stp_state_set
>   - don't change code flow of bcm_sf2_sw_br_set_stp_state
>   - prefer netdev_err over netdev_warn
>
> Vivien Didelot (3):
>   net: dsa: make the STP state function return void
>   net: dsa: make the FDB add function return void
>   net: dsa: make the VLAN add function return void

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
--
Florian