linux-kernel - Re: [PATCH v2] staging: iio: ad7606: use iio_device_{claim|release}_direct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57057A4E.208@metafoo.de>
Date:	Wed, 6 Apr 2016 23:06:22 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Alison Schofield <amsfield22@...il.com>, jic23@...nel.org,
	linux-iio@...r.kernel.org
Cc:	knaack.h@....de, Michael.Hennerich@...log.com, pmeerw@...erw.net,
	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: iio: ad7606: use
 iio_device_{claim|release}_direct_mode()

On 04/06/2016 06:11 AM, Alison Schofield wrote:
> Replace the code that guarantees the device stays in direct mode with
> iio_device_{claim|release}_direct_mode() which does same.
> 
> Signed-off-by: Alison Schofield <amsfield22@...il.com>

Looks good, thanks.

Acked-by: Lars-Peter Clausen <lars@...afoo.de>

> ---
> Changed in v2:
>  - removed improper application of claim/release from intr handler
>  - updated changelog
> 
>  drivers/staging/iio/adc/ad7606_core.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7606_core.c b/drivers/staging/iio/adc/ad7606_core.c
> index 6dbc811..f79ee61 100644
> --- a/drivers/staging/iio/adc/ad7606_core.c
> +++ b/drivers/staging/iio/adc/ad7606_core.c
> @@ -88,12 +88,12 @@ static int ad7606_read_raw(struct iio_dev *indio_dev,
>  
>  	switch (m) {
>  	case IIO_CHAN_INFO_RAW:
> -		mutex_lock(&indio_dev->mlock);
> -		if (iio_buffer_enabled(indio_dev))
> -			ret = -EBUSY;
> -		else
> -			ret = ad7606_scan_direct(indio_dev, chan->address);
> -		mutex_unlock(&indio_dev->mlock);
> +		ret = iio_device_claim_direct_mode(indio_dev);
> +		if (ret)
> +			return ret;
> +
> +		ret = ad7606_scan_direct(indio_dev, chan->address);
> +		iio_device_release_direct_mode(indio_dev);
>  
>  		if (ret < 0)
>  			return ret;
>