linux-kernel - Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Apr 2016 23:16:11 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Appana Durga Kedareswara Rao <appana.durga.rao@...inx.com>,
	Soren Brinkmann <sorenb@...inx.com>
Cc:	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	Michal Simek <michals@...inx.com>,
	"vinod.koul@...el.com" <vinod.koul@...el.com>,
	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	"moritz.fischer@...us.com" <moritz.fischer@...us.com>,
	"laurent.pinchart@...asonboard.com" 
	<laurent.pinchart@...asonboard.com>,
	"luis@...ethencourt.com" <luis@...ethencourt.com>,
	Srikanth Vemula <svemula@...inx.com>,
	Anirudha Sarangi <anirudh@...inx.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>
Subject: Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix
 to dma-chan

On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote:
> Hi Soren,
> 
> 
>> -----Original Message-----
>> From: Sören Brinkmann [mailto:soren.brinkmann@...inx.com]
>> Sent: Wednesday, April 06, 2016 9:50 PM
>> To: Appana Durga Kedareswara Rao <appanad@...inx.com>
>> Cc: robh+dt@...nel.org; pawel.moll@....com; mark.rutland@....com;
>> ijc+devicetree@...lion.org.uk; galak@...eaurora.org; Michal Simek
>> <michals@...inx.com>; vinod.koul@...el.com; dan.j.williams@...el.com;
>> Appana Durga Kedareswara Rao <appanad@...inx.com>;
>> moritz.fischer@...us.com; laurent.pinchart@...asonboard.com;
>> luis@...ethencourt.com; Srikanth Vemula <svemula@...inx.com>; Anirudha
>> Sarangi <anirudh@...inx.com>; devicetree@...r.kernel.org; linux-arm-
>> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
>> dmaengine@...r.kernel.org
>> Subject: Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan
>> prefix to dma-chan
>>
>> On Wed, 2016-04-06 at 21:45:31 +0530, Kedareswara rao Appana wrote:
>>> This patch renames the vdma-mm2s-channel/vdma-s2mm-channel
>>> property with dma-mm2s-channel/dma-s2mm-channel to sync with the
>>> driver.
>>>
>>> Signed-off-by: Kedareswara rao Appana <appanad@...inx.com>
>>> ---
>>> Changes for v3:
>>> ---> New patch.
>>>
>>>  Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 8
>>> ++++----
>>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
>>> b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
>>> index a86737c..762938f 100644
>>> --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
>>> +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
>>> @@ -24,8 +24,8 @@ Optional properties:
>>>  	{3}, flush s2mm channel
>>>
>>>  Required child node properties:
>>> -- compatible: It should be either "xlnx,axi-vdma-mm2s-channel" or
>>> -	"xlnx,axi-vdma-s2mm-channel".
>>> +- compatible: It should be either "xlnx,axi-dma-mm2s-channel" or
>>> +	"xlnx,axi-dma-s2mm-channel".
>>
>> This change is not backwards compatible and breaks every user of the current
>> binding.
> 
> This commit http://git.kernel.org/cgit/linux/kernel/git/vkoul/slave-dma.git/commit/?h=next&id=8e66e7d682b04f7141f8ae666908c8dcd7fc0bfa 
> Renames xilinx_vdma_ prefix to xilinx_dma which includes renaming of the above properties.
> The patch (dmaengine: vdma: Rename xilinx_vdma_ prefix to xilinx_dma) already got applied in the dma-next tree.
> That's why sent this patch to sync with the current driver I mean latest driver.

The correct solution for this is to revert that part of the change ASAP,
since, as Soeren pointed out, it breaks all existing users.

Thanks,
- Lars