linux-kernel - Re: [PART1 RFC v3 12/12] svm: Manage vcpu load/unload when enable AVIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57048521.80509@amd.com>
Date:	Wed, 6 Apr 2016 10:40:17 +0700
From:	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
To:	Radim Krčmář <rkrcmar@...hat.com>
CC:	<pbonzini@...hat.com>, <joro@...tes.org>, <bp@...en8.de>,
	<gleb@...nel.org>, <alex.williamson@...hat.com>,
	<kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<wei@...hat.com>, <sherry.hurwitz@....com>
Subject: Re: [PART1 RFC v3 12/12] svm: Manage vcpu load/unload when enable
 AVIC

Radim,

On 04/05/2016 09:56 PM, Radim Krčmář wrote:
> I meant to change the place where we remember that is_running must not
> be true.  Something like
>
>    svm_vcpu_blocking(struct kvm_vcpu *vcpu):
>           vcpu->is_blocking = true;
>           avic_set_running(vcpu, false);
>
>    avic_vcpu_load(struct kvm_vcpu *vcpu, bool is_load):
>           avic_set_running(vcpu, is_load && !vcpu->is_blocking)

I assume that you also imply that we would also need:

	svm_vcpu_unblocking(struct kvm_vcpu *vcpu) {
		avic_set_running(vcpu, false);
		vcpu->is_blocking = false;
	}

Thanks,
Suravee