linux-kernel - Re: [PATCH v2] PM / runtime: Document steps for device removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1951186.4KzpkCHJdR@vostro.rjw.lan>
Date:	Thu, 07 Apr 2016 01:34:44 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Alan Stern <stern@...land.harvard.edu>,
	Krzysztof Kozlowski <krzk@...nel.org>
Cc:	Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] PM / runtime: Document steps for device removal

On Sunday, April 03, 2016 02:27:27 PM Alan Stern wrote:
> On Sun, 3 Apr 2016, Krzysztof Kozlowski wrote:
> 
> > Put a reminder that during device removal drivers should revert all PM
> > runtime changes from the probe.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> > 
> > ---
> > 
> > Changes since v1:
> > 1. Address Alan's comments.
> > ---
> >  Documentation/power/runtime_pm.txt | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/power/runtime_pm.txt b/Documentation/power/runtime_pm.txt
> > index 7328cf85236c..1fd1fbe9ce95 100644
> > --- a/Documentation/power/runtime_pm.txt
> > +++ b/Documentation/power/runtime_pm.txt
> > @@ -586,6 +586,10 @@ drivers to make their ->remove() callbacks avoid races with runtime PM directly,
> >  but also it allows of more flexibility in the handling of devices during the
> >  removal of their drivers.
> >  
> > +Drivers in ->remove() callback should undo the runtime PM changes done
> > +in ->probe(). Usually this means calling pm_runtime_disable(),
> > +pm_runtime_dont_use_autosuspend() etc.
> > +
> >  The user space can effectively disallow the driver of the device to power manage
> >  it at run time by changing the value of its /sys/devices/.../power/control
> >  attribute to "on", which causes pm_runtime_forbid() to be called.  In principle,
> 
> Acked-by: Alan Stern <stern@...land.harvard.edu>

Applied, thanks!