linux-kernel - Re: [PATCH v10 8/9] usb: xhci: Add NVIDIA Tegra XUSB controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160407110501.GA10231@ulmo.ba.sec>
Date:	Thu, 7 Apr 2016 13:05:01 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Mathias Nyman <mathias.nyman@...ux.intel.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mathias Nyman <mathias.nyman@...el.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Andrew Bresticker <abrestic@...omium.org>,
	linux-tegra@...r.kernel.org, devicetree@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 8/9] usb: xhci: Add NVIDIA Tegra XUSB controller
 driver

On Thu, Apr 07, 2016 at 02:03:45PM +0300, Mathias Nyman wrote:
> On 04.03.2016 18:19, Thierry Reding wrote:
> > From: Thierry Reding <treding@...dia.com>
> > 
> > Add support for the on-chip XUSB controller present on Tegra SoCs. This
> > controller, when loaded with external firmware, exposes an interface
> > compliant with xHCI. This driver loads the firmware, starts the
> > controller, and is able to service host-specific messages sent by the
> > controller's firmware.
> > 
> > The controller also supports USB device mode as well as powergating
> > of the SuperSpeed and host-controller logic when not in use, but
> > support for these is not yet implemented.
> > 
> > Based on work by:
> >    Ajay Gupta <ajayg@...dia.com>
> >    Bharath Yadav <byadav@...dia.com>
> >    Andrew Bresticker <abrestic@...omium.org>
> > 
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: Mathias Nyman <mathias.nyman@...el.com>
> > Signed-off-by: Thierry Reding <treding@...dia.com>
> > ---
> 
> ...
> 
> > +static int tegra_xusb_remove(struct platform_device *pdev)
> > +{
> > +	struct tegra_xusb *tegra = platform_get_drvdata(pdev);
>  > +	struct usb_hcd *hcd = tegra->hcd;
> > +	struct xhci_hcd *xhci;
> > +
> > +	if (tegra->fw_loaded) {
> > +		xhci = hcd_to_xhci(hcd);
> > +		usb_remove_hcd(xhci->shared_hcd);
> > +		usb_put_hcd(xhci->shared_hcd);
> > +		usb_remove_hcd(hcd);
> > +		tegra_xusb_padctl_put(tegra->padctl);
> > +		usb_put_hcd(hcd);
> > +		kfree(xhci);
> 
> Don't free xhci here, xhci is a part of hcd (hcd_priv) and hcd is already freed in usb_put_hcd()

Ah, this was indeed reported to me about two weeks ago and fixed since
then in my local tree.

> Other than that I can't see any issues

Thanks. Does this count as an Acked-by provided the kfree() is removed?

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)