| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5705B5FE.8030105@linux.intel.com>
Date: Thu, 7 Apr 2016 09:21:02 +0800
From: Yang Jie <yang.jie@...ux.intel.com>
To: Dan Carpenter <dan.carpenter@...cle.com>
Cc: alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
Takashi Iwai <tiwai@...e.com>, Mark Brown <broonie@...nel.org>
Subject: Re: [alsa-devel] [patch] ASoC: Intel: sst: fix a loop timeout in
sst_hsw_stream_reset()
On 2016年04月06日 19:36, Dan Carpenter wrote:
> In the original code we ended the loop with tries set to -1 instead of
> zero.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
Acked-by: Jie Yang <yang.jie@...el.com>
Dan, thanks for finding and correcting it.
Thanks,
~Keyon
> ---
> Not tested.
>
> diff --git a/sound/soc/intel/haswell/sst-haswell-ipc.c b/sound/soc/intel/haswell/sst-haswell-ipc.c
> index ac60f13..9156522 100644
> --- a/sound/soc/intel/haswell/sst-haswell-ipc.c
> +++ b/sound/soc/intel/haswell/sst-haswell-ipc.c
> @@ -1345,7 +1345,7 @@ int sst_hsw_stream_reset(struct sst_hsw *hsw, struct sst_hsw_stream *stream)
> return 0;
>
> /* wait for pause to complete before we reset the stream */
> - while (stream->running && tries--)
> + while (stream->running && --tries)
> msleep(1);
> if (!tries) {
> dev_err(hsw->dev, "error: reset stream %d still running\n",
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
Powered by blists - more mailing lists