linux-kernel - Re: [PATCH v2 2/2] usb: musb: pic32: Add USB DRC driver for PIC32 OTG controller.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Apr 2016 18:23:27 +0530
From:	Purna Chandra Mandal <purna.mandal@...rochip.com>
To:	Felipe Balbi <felipe.balbi@...ux.intel.com>,
	<linux-kernel@...r.kernel.org>
CC:	Rob Herring <robh+dt@...nel.org>, <linux-usb@...r.kernel.org>,
	Joshua Henderson <digitalpeer@...italpeer.com>,
	Cristian Birsan <cristian.birsan@...rochip.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Bin Liu <b-liu@...com>, Kumar Gala <galak@...eaurora.org>
Subject: Re: [PATCH v2 2/2] usb: musb: pic32: Add USB DRC driver for PIC32 OTG
 controller.

On 04/07/2016 06:09 PM, Felipe Balbi wrote:

> Purna Chandra Mandal <purna.mandal@...rochip.com> writes:
>> From: Cristian Birsan <cristian.birsan@...rochip.com>
>>
>> This driver adds support of PIC32 MUSB OTG controller as
>> dual role device. It implements platform specific glue to
>> reuse musb core.
>>
>> Signed-off-by: Cristian Birsan <cristian.birsan@...rochip.com>
>> Signed-off-by: Purna Chandra Mandal <purna.mandal@...rochip.com>
>>
>> In-reply-to: 460027775-20729-2-git-send-email-purna.mandal@...rochip.com
>>
>> ---
>>
>> Changes in v2:
>>  - fix i386 build
>>  - fix indentation
>>
>>  drivers/usb/musb/Kconfig  |   9 +-
>>  drivers/usb/musb/Makefile |   1 +
>>  drivers/usb/musb/pic32.c  | 608 ++++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 617 insertions(+), 1 deletion(-)
>>  create mode 100644 drivers/usb/musb/pic32.c
>>
>> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
>> index 886526b..1970c1e 100644
>> --- a/drivers/usb/musb/Kconfig
>> +++ b/drivers/usb/musb/Kconfig
>> @@ -112,6 +112,13 @@ config USB_MUSB_BLACKFIN
>>  	depends on (BF54x && !BF544) || (BF52x && ! BF522 && !BF523)
>>  	depends on NOP_USB_XCEIV
>>  
>> +config USB_MUSB_PIC32
>> +	tristate "Microchip PIC32 USB platforms"
>> +	depends on MACH_PIC32
> no, we like to build stuff on other arches, this should be:
>
> 	depends on MACH_PIC32 || COMPILE_TEST
>
> and you should *really* fix the build error, not work around it.

This driver is for PIC32MZDA platforms which are powered by MIPS 14Kec CPU.

The offending API 'readsl()' is implemented by MIPS arch (in
arch/mips/include/asm/io.h), but not by i386 arch.

IMO compiling for i386 is not required.