linux-kernel - Re: [PATCH] usb: f_mass_storage: test whether thread is running before starting another

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1604071024100.2179-100000@iolanthe.rowland.org>
Date:	Thu, 7 Apr 2016 10:25:30 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Michal Nazarewicz <mina86@...a86.com>
cc:	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	Tony Lindgren <tony@...mide.com>,
	<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	Felipe Balbi <felipe.balbi@...ux.intel.com>,
	Bin Liu <b-liu@...com>, <pali.rohar@...il.com>
Subject: Re: [PATCH] usb: f_mass_storage: test whether thread is running
 before starting another

On Thu, 7 Apr 2016, Michal Nazarewicz wrote:

> Sounds good to me.  I’d love someone to test this patch (I sadly have no
> way of doing that at the moment) and with that I can resend it with
> updated message.

Ivaylo should be able to try it.

> > BTW, is configfs capable of adding a single instance twice in different 
> > configs?  Or is that again something only legacy gadgets can do?
> 
> I don’t think so.  I might be wrong though, but here’s configuration
> from the original post:
> 
> 	mkdir functions/mass_storage.0
> 	echo $file > functions/mass_storage.0/lun.0/file
> 	ln -s functions/mass_storage.0 configs/c.1
> 	ln -s functions/mass_storage.0 configs/c.2
> 
> This makes me suspect it’s not possible to link a function instance to
> the same configuration twice, but now that I think about it, I’m not
> quite sure what would happen if one did:
> 
> 	ln -s functions/mass_storage.0 configs/c.1/foo
> 	ln -s functions/mass_storage.0 configs/c.1/bar

Do you think it would be worthwhile to check for this possibility in 
the driver and report an error?

Alan Stern