linux-kernel - Re: [PATCH] usb: core: hub: hub_port_init lock controller instead of bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160407174028.GA14673@localhost>
Date:	Thu, 7 Apr 2016 18:40:28 +0100
From:	Chris Bainbridge <chris.bainbridge@...il.com>
To:	Mathias Nyman <mathias.nyman@...ux.intel.com>
Cc:	gregkh@...uxfoundation.org, johan@...nel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	stern@...land.harvard.edu
Subject: Re: [PATCH] usb: core: hub: hub_port_init lock controller instead of
 bus

On Wed, Feb 10, 2016 at 07:13:38PM +0200, Mathias Nyman wrote:
> 
> Most likely xhci is messed up after two device slots are in default state at the same time.
> This happens when both threads are in hub_port_init() have called hub_port_reset()
> 
> The issue becomes visible when the the descriptor read and set address both fail after
> the port resets.
> 
> xhci specs 4.5.3 has one tiny note about this:
> "Note: Software shall not transition more than one Device Slot to the Default State at a time"
> 
> So to me, and from xhci pov this patch looks like the correct solution,
> but I might be missing some usb core side details.
> 
> -Mathias
> 

Just following up to see if this patch disappeared into the void?