linux-kernel - Re: [PATCH v5 2/2] mm, thp: avoid unnecessary swapin in khugepaged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201604080155.9NHtyZH5%fengguang.wu@intel.com>
Date:	Fri, 8 Apr 2016 01:48:45 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Ebru Akagunduz <ebru.akagunduz@...il.com>
Cc:	kbuild-all@...org, linux-mm@...ck.org, hughd@...gle.com,
	riel@...hat.com, akpm@...ux-foundation.org,
	kirill.shutemov@...ux.intel.com, n-horiguchi@...jp.nec.com,
	aarcange@...hat.com, iamjoonsoo.kim@....com, gorcunov@...nvz.org,
	linux-kernel@...r.kernel.org, mgorman@...e.de, rientjes@...gle.com,
	vbabka@...e.cz, aneesh.kumar@...ux.vnet.ibm.com,
	hannes@...xchg.org, mhocko@...e.cz, boaz@...xistor.com,
	Ebru Akagunduz <ebru.akagunduz@...il.com>
Subject: Re: [PATCH v5 2/2] mm, thp: avoid unnecessary swapin in khugepaged

Hi Ebru,

[auto build test ERROR on next-20160407]
[cannot apply to v4.6-rc2 v4.6-rc1 v4.5-rc7 v4.6-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Ebru-Akagunduz/mm-thp-Fix-unnecessarry-resource-consuming-in-swapin/20160408-013104
config: i386-randconfig-x016-201614 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from include/asm-generic/bug.h:4:0,
                    from arch/x86/include/asm/bug.h:35,
                    from include/linux/bug.h:4,
                    from include/linux/mmdebug.h:4,
                    from include/linux/mm.h:8,
                    from mm/huge_memory.c:10:
   mm/huge_memory.c: In function 'collapse_huge_page':
>> include/linux/compiler.h:149:57: error: expected expression before ')' token
    #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
                                                            ^
   include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^
>> mm/huge_memory.c:2516:2: note: in expansion of macro 'if'
     if (allocstall == curr_allocstall && swap !=)
     ^
>> include/linux/compiler.h:149:57: error: expected expression before ')' token
    #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
                                                            ^
   include/linux/compiler.h:162:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^
>> mm/huge_memory.c:2516:2: note: in expansion of macro 'if'
     if (allocstall == curr_allocstall && swap !=)
     ^

vim +/if +2516 mm/huge_memory.c

  2500		if (!hugepage_vma_check(vma)) {
  2501			result = SCAN_VMA_CHECK;
  2502			goto out;
  2503		}
  2504		pmd = mm_find_pmd(mm, address);
  2505		if (!pmd) {
  2506			result = SCAN_PMD_NULL;
  2507			goto out;
  2508		}
  2509	
  2510		swap = get_mm_counter(mm, MM_SWAPENTS);
  2511		curr_allocstall = sum_vm_event(ALLOCSTALL);
  2512		/*
  2513		 * When system under pressure, don't swapin readahead.
  2514		 * So that avoid unnecessary resource consuming.
  2515		 */
> 2516		if (allocstall == curr_allocstall && swap !=)
  2517			__collapse_huge_page_swapin(mm, vma, address, pmd);
  2518	
  2519		anon_vma_lock_write(vma->anon_vma);
  2520	
  2521		pte = pte_offset_map(pmd, address);
  2522		pte_ptl = pte_lockptr(mm, pmd);
  2523	
  2524		mmun_start = address;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (28842 bytes)