lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1460052276.1800.3.camel@perches.com>
Date:	Thu, 07 Apr 2016 11:04:36 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>,
	Nicholas Sim <nicholassimws@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8192u: remove blank lines after braces
 (opening)

On Thu, 2016-04-07 at 20:59 +0300, Andy Shevchenko wrote:
> On Tue, Apr 5, 2016 at 7:07 PM, Nicholas Sim <nicholassimws@...il.com> wrote:
> > 
> > Remove unneeded blank lines appearing after opening braces as suggested
> > by checkpatch.pl
> > 
> You have to combine this with the rest so called 'indentation' fixes,
> e.g. +- empty lines, tabs vs. spaces, etc.

Actually, patches that do single things like removing
undesired blank lines are easier to review if separate
from patches that change horizontal whitespace.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ