linux-kernel - Re: [PATCH] staging: rtl8192u: remove blank lines after braces (opening)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1460052716.1800.5.camel@perches.com>
Date:	Thu, 07 Apr 2016 11:11:56 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Nicholas Sim <nicholassimws@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8192u: remove blank lines after braces
 (opening)

On Thu, 2016-04-07 at 21:06 +0300, Andy Shevchenko wrote:
> On Thu, Apr 7, 2016 at 9:04 PM, Joe Perches <joe@...ches.com> wrote:
> > On Thu, 2016-04-07 at 20:59 +0300, Andy Shevchenko wrote:
> > > On Tue, Apr 5, 2016 at 7:07 PM, Nicholas Sim  wrote:
> > > > 
> > > > Remove unneeded blank lines appearing after opening braces as suggested
> > > > by checkpatch.pl
> > > > 
> > > You have to combine this with the rest so called 'indentation' fixes,
> > > e.g. +- empty lines, tabs vs. spaces, etc.
> > Actually, patches that do single things like removing
> > undesired blank lines are easier to review if separate
> > from patches that change horizontal whitespace.
> > 
> Okay, but I think you at least agree that +- empty lines can be easily combined.

Not really, but it's not important enough to me to care much
either way.