linux-kernel - Re: livepatch: robustify klp_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160407182030.GA25804@packer-debian-8-amd64.digitalocean.com>
Date:	Thu, 7 Apr 2016 14:20:30 -0400
From:	Jessica Yu <jeyu@...hat.com>
To:	Jiri Kosina <jikos@...nel.org>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	Josh Poimboeuf <jpoimboe@...hat.com>,
	Miroslav Benes <mbenes@...e.cz>,
	Petr Mladek <pmladek@...e.com>, live-patching@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: livepatch: robustify klp_register_patch() API error checking

+++ Jiri Kosina [07/04/16 18:06 +0200]:
>From: Jiri Kosina <jkosina@...e.cz>
>
>Commit 425595a7fc20 ("livepatch: reuse module loader code to write
>relocations") adds a possibility of dereferncing pointers supplied by the
>consumer of the livepatch API before sanity (NULL) checking them (patch
>and patch->mod).
>
>Spotted by smatch tool.
>
>Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
>Signed-off-by: Jiri Kosina <jkosina@...e.cz>

Acked-by: Jessica Yu <jeyu@...hat.com>

Thank you Jiri!