linux-kernel - Re: [PATCH v2 09/30] Add tile-specific parity functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Apr 2016 11:55:55 +0800
From:	Zeng Zhaoxiu <zhaoxiu.zeng@...il.com>
To:	Chris Metcalf <cmetcalf@...lanox.com>, zengzhaoxiu@....com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 09/30] Add tile-specific parity functions

在 2016年04月06日 21:27, Chris Metcalf 写道:
> On 4/6/2016 5:08 AM, zengzhaoxiu@....com wrote:
>> From: Zhaoxiu Zeng<zhaoxiu.zeng@...il.com>
>>
>> Signed-off-by: Zhaoxiu Zeng<zhaoxiu.zeng@...il.com>
>> ---
>>   arch/tile/include/asm/bitops.h | 26 ++++++++++++++++++++++++++
>>   1 file changed, 26 insertions(+)
>
> Since all the code you are adding here is architecture-independent,
> I think it would make more sense to have it be in a file like
> include/asm-generic/bitops/parity-popcount.h, which can then
> be included from arch/tile/include/asm/bitops.h.
>

Agreed, thanks!