linux-kernel - Re: [PATCH 09/27] target: use bio_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVXFVPL7x8aozVTnKfJUJAEpzKogdcjR8vAmJmd+BzuFzEnWg@mail.gmail.com>
Date:	Thu, 7 Apr 2016 12:07:07 +0800
From:	Ming Lei <tom.leiming@...il.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Jens Axboe <axboe@...com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-block@...r.kernel.org, Boaz Harrosh <boaz@...xistor.com>,
	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
	"open list:TARGET SUBSYSTEM" <linux-scsi@...r.kernel.org>,
	"open list:TARGET SUBSYSTEM" <target-devel@...r.kernel.org>
Subject: Re: [PATCH 09/27] target: use bio_is_full()

On Tue, Apr 5, 2016 at 9:02 PM, Christoph Hellwig <hch@...radead.org> wrote:
> On Tue, Apr 05, 2016 at 07:56:54PM +0800, Ming Lei wrote:
>> +++ b/drivers/target/target_core_pscsi.c
>> @@ -951,7 +951,7 @@ pscsi_map_sg(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents,
>>                       pr_debug("PSCSI: bio->bi_vcnt: %d nr_vecs: %d\n",
>>                               bio->bi_vcnt, nr_vecs);
>>
>> -                     if (bio->bi_vcnt > nr_vecs) {
>> +                     if (bio_is_full(bio)) {
>>                               pr_debug("PSCSI: Reached bio->bi_vcnt max:"
>>                                       " %d i: %d bio: %p, allocating another"
>>                                       " bio\n", bio->bi_vcnt, i, bio);
>
> This check should be removed entirely - bio_add_pc_page takes care of
> it.

OK.


-- 
Ming Lei