linux-kernel - [PATCH] perf build: Fix syscall table dependency error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Apr 2016 06:35:25 +0000
From:	Wang Nan <wangnan0@...wei.com>
To:	<acme@...nel.org>
CC:	<pi3orama@....com>, <linux-kernel@...r.kernel.org>,
	<lizefan@...wei.com>, <wangnan0@...wei.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	David Ahern <dsahern@...il.com>, Jiri Olsa <jolsa@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>
Subject: [PATCH] perf build: Fix syscall table dependency error

Commit 42abeef7e8df ("perf tools: Build syscall table .c header from
kernel's syscall_64.tbl") introduces archheaders dependency. It is
added to 'prepare', but not added directly to libperf-in.o, causes
following error:

 $ make -C ./tools/perf/ O=/tmp/xxxxx/ /tmp/xxxxx/libperf-in.o JOBS=1
 make: Entering directory `/xx/xx/tools/perf'
 BUILD:   Doing 'make -j1' parallel build

 Auto-detecting system features:
 ...                         dwarf: [ on  ]
 ...            dwarf_getlocations: [ on  ]
 <SNIP>
   CC       /tmp/xxxxx/util/map.o
   CC       /tmp/xxxxx/util/pstack.o
   CC       /tmp/xxxxx/util/session.o
   make[3]: *** No rule to make target `/tmp/xxxxx/arch/x86/include/generated/asm/syscalls_64.c', needed by `/tmp/xxxxx/util/syscalltbl.o'.  Stop.
   make[2]: *** [util] Error 2
   make[1]: *** [/tmp/xxxxx/libperf-in.o] Error 2
   make: *** [/tmp/xxxxx/libperf-in.o] Error 2
   make: Leaving directory `/home/w00229757/kernel-hydrogen/tools/perf'

In parallel building this missing dependency causes building error.

Add 'prepare' to libperf-in's dependency.

Signed-off-by: Wang Nan <wangnan0@...wei.com>
Cc: Adrian Hunter <adrian.hunter@...el.com>
Cc: David Ahern <dsahern@...il.com>
Cc: Jiri Olsa <jolsa@...nel.org>
Cc: Namhyung Kim <namhyung@...nel.org>
---
 tools/perf/Makefile.perf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 1469aea..bde8cba 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -433,7 +433,7 @@ $(patsubst perf-%,%.o,$(PROGRAMS)): $(wildcard */*.h)
 
 LIBPERF_IN := $(OUTPUT)libperf-in.o
 
-$(LIBPERF_IN): fixdep FORCE
+$(LIBPERF_IN): prepare fixdep FORCE
 	$(Q)$(MAKE) $(build)=libperf
 
 $(LIB_FILE): $(LIBPERF_IN)
-- 
1.8.3.4