linux-kernel - Re: [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <570782BF.10402@synopsys.com>
Date:	Fri, 8 Apr 2016 11:06:55 +0100
From:	Jose Abreu <Jose.Abreu@...opsys.com>
To:	Mark Brown <broonie@...nel.org>,
	Jose Abreu <Jose.Abreu@...opsys.com>
CC:	<linux-snps-arc@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
	<alsa-devel@...a-project.org>, <CARLOS.PALMINHA@...opsys.com>,
	<Alexey.Brodkin@...opsys.com>, <Vineet.Gupta1@...opsys.com>,
	<architt@...eaurora.org>, <airlied@...ux.ie>,
	<lgirdwood@...il.com>, <perex@...ex.cz>, <tiwai@...e.com>
Subject: Re: [PATCH 5/5 v4] ASoC: dwc: Update DOCUMENTATION for I2S Driver

Hi Mark,

On 07-04-2016 18:53, Mark Brown wrote:
> On Thu, Apr 07, 2016 at 05:53:59PM +0100, Jose Abreu wrote:
>
>> + Optional properties:
>> + - snps,use-dmaengine: If set the driver will use ALSA DMA engine. If set
>> +   it is required to use the properties 'dmas' and 'dma-names'.
> This is not a good interface, it's describing Linux internal APIs.  If
> the device needs to operate in PIO mode it should just do that.

I added this interface because there is no direct way to check if DMA is
available on the I2S controller so it is not possible to automatically change
between DMA and PIO mode. As the I2S controller can be built with or without DMA
support it is necessary to somehow check if DMA is enabled or not and according
to that use either ALSA DMA engine or the custom platform driver sent in these
patches. I did not want to remove drivers functionality so I added this property
to the DT. This way a user can select between DMA and PIO mode.

Is there a better option to do this without removing the possibility of using
ALSA DMA engine in the driver?

Best regards,
Jose Miguel Abreu