linux-kernel - Re: [PATCH v2] stm class: correct masterID range in setting via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a8l4xn9f.fsf@ashishki-desk.ger.corp.intel.com>
Date:	Fri, 08 Apr 2016 16:07:08 +0300
From:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To:	Chunyan Zhang <zhang.chunyan@...aro.org>
Cc:	linux-kernel@...r.kernel.org, zhang.lyra@...il.com,
	mathieu.poirier@...aro.org
Subject: Re: [PATCH v2] stm class: correct masterID range in setting via sysfs

Chunyan Zhang <zhang.chunyan@...aro.org> writes:

> The type of masterID is defined as 'unsigned int', theoretically one
> can set masterID with a number larger than 'INT_MAX' as long as
> 'stm_data::sw_end' is larger than 'INT_MAX'.
>
> Also, 'stm_data::start' and 'stm_data::end' is initialized in respective
> drivers which should be able to use any value less than 'UINT_MAX' for
> their masterIDs, of course including those values larger than 'INT_MAX',

Actually, STP specification allows up to 65536 masters ([0..65535]), so
technically there's no problem. :)

The comparisons are still bogus, though. I'll amend your commit message.

Thanks,
--
Alex