linux-kernel - Re: [PATCHv2] usb: f_mass_storage: test whether thread is running before starting another

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 8 Apr 2016 11:19:45 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Michal Nazarewicz <mina86@...a86.com>
cc:	Felipe Balbi <felipe.balbi@...ux.intel.com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	<stable@...r.kernel.org>
Subject: Re: [PATCHv2] usb: f_mass_storage: test whether thread is running
 before starting another

On Fri, 8 Apr 2016, Michal Nazarewicz wrote:

> When binding the function to usb_configuration, check whether the thread
> is running before starting another one.  Without that, when function
> instance is added to multiple configurations, fsg_bing starts multiple
> threads with all but the latest one being forgotten by the driver.  This
> leads to obvious thread leaks, possible lockups when trying to halt the
> machine and possible more issues.
> 
> This fixes issues with legacy/multi¹ gadget as well as configfs gadgets
> when mass_storage function is added to multiple configurations.
> 
> This change also simplifies API since the legacy gadgets no longer need
> to worry about starting the thread by themselves (which was where bug
> in legacy/multi was in the first place).
> 
> N.B., this patch doesn’t address adding single mass_storage function
> instance to a single configuration twice.  Thankfully, there’s no
> legitimate reason for such setup plus, if I’m not mistaken, configfs
> gadget doesn’t even allow it to be expressed.
> 
> ¹ I have no example failure though.  Conclusion that legacy/multi has
>   a bug is based purely on me reading the code.
> 
> Signed-off-by: Michal Nazarewicz <mina86@...a86.com>
> Tested-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
> Cc: Alan Stern <stern@...land.harvard.edu>
> Cc: stable@...r.kernel.org

Acked-by: Alan Stern <stern@...land.harvard.edu>