linux-kernel - Re: [PATCH] fs/gfs2/glock.c: Deinline do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57080A80.3090201@redhat.com>
Date:	Fri, 08 Apr 2016 21:46:08 +0200
From:	Denys Vlasenko <dvlasenk@...hat.com>
To:	Bob Peterson <rpeterso@...hat.com>
CC:	Steven Whitehouse <swhiteho@...hat.com>, cluster-devel@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/gfs2/glock.c: Deinline do_error, save 1856 bytes

On 04/08/2016 09:17 PM, Bob Peterson wrote:
> ----- Original Message -----
>> This function compiles to 522 bytes of machine code.
>>
> Is there a reason why you want to trade memory for speed? Are you
> optimizing for memory on an embedded device or something?

Yes. I did a scan for really large inlines and this function came up.
If you feel it is indeed performance critical, please ignore my patch.