linux-kernel - Re: [PATCH-V2 1/1] HID: Force feedback support for the Logitech G920

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 8 Apr 2016 23:34:14 +0200
From:	Elias Vanderstuyft <elias.vds@...il.com>
To:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jiri Kosina <jikos@...nel.org>
Cc:	Simon Wood <simon@...gewell.org>, Edwin Velds <e.velds@...il.com>,
	"open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
	Michal Maly <madcatxster@...oid-pointer.net>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [PATCH-V2 1/1] HID: Force feedback support for the Logitech G920

On Thu, Jan 28, 2016 at 2:33 PM, Jiri Kosina <jikos@...nel.org> wrote:
> On Tue, 26 Jan 2016, Simon Wood wrote:
>
>> On Sun, January 10, 2016 4:25 pm, Edwin Velds wrote:
>> > This patch implements force feedback support for the Logitech
>> > G920 Driving Force Racing Wheel. It is a generic implementation
>> > of feature 0x8123 of the Logitech HID++ protocol and should be usable for
>> > any future devices that implement this feature.
>>
>> Apologies for being slow on this (something to do with changing jobs and
>> accomodation ;-).
>>
>> Doesn't patch cleanly on Linus' HEAD due to:
>> --
>> commit d8ce9bf5551bfea431893bdd0a943f24a5170828
>> Author: Geliang Tang <geliangtang@....com>
>> Date:   Sun Dec 27 17:25:20 2015 +0800
>>
>>     HID: move to_hid_device() to hid.h
>
> I've fixed the conflict.
>
>> --
>>
>> A couple of white space issues:
>> --
>> ERROR: trailing whitespace
>> #114: FILE: drivers/hid/hid-logitech-hidpp.c:867:
>> +static const u8 HIDPP_FF_CONDITION_CMDS[] = { $
>>
>> ERROR: trailing whitespace
>> #121: FILE: drivers/hid/hid-logitech-hidpp.c:874:
>> +static const char *HIDPP_FF_CONDITION_NAMES[] = { $
>
> Fixed as well.
>
>> --
>>
>> Note: The wheel _DOES_NOT_ auto switch to Logitech/HID mode (it is stuck
>> in XBox since the xpad changes where not included). Michal has an
>> alternative approach documented here:
>
> I've ammended the changelog with this information.

Here is the official post on the usb_modeswitch forum:
http://www.draisberghof.de/usb_modeswitch/bb/viewtopic.php?f=2&t=2510
It will be included in the next usb-modeswitch-data release.

Thanks,
Elias