linux-kernel - Re: [PATCH] ALSA: constify ct_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hh9fbcg1f.wl-tiwai@suse.de>
Date:	Sat, 09 Apr 2016 11:01:00 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	"Julia Lawall" <Julia.Lawall@...6.fr>
Cc:	"Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
	<kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: constify ct_timer_ops structures

On Sat, 09 Apr 2016 10:36:15 +0200,
Julia Lawall wrote:
> 
> The ct_timer_ops structures are never modified, so declare them as const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Applied, thanks.


Takashi

> 
> ---
>  sound/pci/ctxfi/cttimer.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/pci/ctxfi/cttimer.c b/sound/pci/ctxfi/cttimer.c
> index a5d4604..8f94534 100644
> --- a/sound/pci/ctxfi/cttimer.c
> +++ b/sound/pci/ctxfi/cttimer.c
> @@ -49,7 +49,7 @@ struct ct_timer {
>  	spinlock_t lock;		/* global timer lock (for xfitimer) */
>  	spinlock_t list_lock;		/* lock for instance list */
>  	struct ct_atc *atc;
> -	struct ct_timer_ops *ops;
> +	const struct ct_timer_ops *ops;
>  	struct list_head instance_head;
>  	struct list_head running_head;
>  	unsigned int wc;		/* current wallclock */
> @@ -128,7 +128,7 @@ static void ct_systimer_prepare(struct ct_timer_instance *ti)
>  
>  #define ct_systimer_free	ct_systimer_prepare
>  
> -static struct ct_timer_ops ct_systimer_ops = {
> +static const struct ct_timer_ops ct_systimer_ops = {
>  	.init = ct_systimer_init,
>  	.free_instance = ct_systimer_free,
>  	.prepare = ct_systimer_prepare,
> @@ -322,7 +322,7 @@ static void ct_xfitimer_free_global(struct ct_timer *atimer)
>  	ct_xfitimer_irq_stop(atimer);
>  }
>  
> -static struct ct_timer_ops ct_xfitimer_ops = {
> +static const struct ct_timer_ops ct_xfitimer_ops = {
>  	.prepare = ct_xfitimer_prepare,
>  	.start = ct_xfitimer_start,
>  	.stop = ct_xfitimer_stop,
> 
>