linux-kernel - Re: [PATCH] iio: ak8975: fix maybe-uninitialized warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <570A60B1.5060706@kernel.org>
Date:	Sun, 10 Apr 2016 15:18:25 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Richard Leitner <dev@...l1n.net>
Cc:	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: ak8975: fix maybe-uninitialized warning

On 05/04/16 14:03, Richard Leitner wrote:
> If i2c_device_id *id is NULL and acpi_match_device returns NULL too,
> then chipset may be unitialized when accessing &ak_def_array[chipset] in
> ak8975_probe. Therefore initialize chipset to AK_MAX_TYPE, which will
> return an error when not changed.
> 
> This patch fixes the following maybe-uninitialized warning:
> 
> drivers/iio/magnetometer/ak8975.c: In function ‘ak8975_probe’:
> drivers/iio/magnetometer/ak8975.c:788:14: warning: ‘chipset’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>   data->def = &ak_def_array[chipset];
> 
> Signed-off-by: Richard Leitner <dev@...l1n.net>
Applied to the fixes-togreg branch of iio.git and marked fo stable.
> ---
>  drivers/iio/magnetometer/ak8975.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/magnetometer/ak8975.c
> b/drivers/iio/magnetometer/ak8975.c index 9c5c9ef..82783dc 100644
> --- a/drivers/iio/magnetometer/ak8975.c
> +++ b/drivers/iio/magnetometer/ak8975.c
> @@ -732,7 +732,7 @@ static int ak8975_probe(struct i2c_client *client,
>  	int eoc_gpio;
>  	int err;
>  	const char *name = NULL;
> -	enum asahi_compass_chipset chipset;
> +	enum asahi_compass_chipset chipset = AK_MAX_TYPE;
>  
>  	/* Grab and set up the supplied GPIO. */
>  	if (client->dev.platform_data)
>