linux-kernel - Re: [patch] power/max8925: freeing wrong variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160410162729.GB25923@earth>
Date:	Sun, 10 Apr 2016 18:27:29 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Haojian Zhuang <haojian.zhuang@...vell.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] power/max8925: freeing wrong variable

Hi,

On Fri, Mar 18, 2016 at 08:40:16AM +0300, Dan Carpenter wrote:
> We were freeing "info->battery" instead of "info->usb", which leads to
> an OOps and a resource leak.
> 
> The labels were wonky, "out_battery" did release the battery but out_usb
> did not release usb.  I was introducing a call to free usb so it sort
> conflicted with existing misleading name.  I renamed them.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Thanks, queued.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)