linux-kernel - RE: [PATCH v2] gpio: pca953x: add PCAL9535 interrupt support for Galileo Gen2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BCE6BEBCDDF4B84E891D2320CBF96F1D3F9C77F1@SHSMSX101.ccr.corp.intel.com>
Date:	Sun, 10 Apr 2016 03:02:29 +0000
From:	"Li, Yong B" <yong.b.li@...el.com>
To:	Linus Walleij <linus.walleij@...aro.org>
CC:	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Alexandre Courbot" <gnurou@...il.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	"Puustinen, Ismo" <ismo.puustinen@...el.com>,
	Phil Reid <preid@...ctromag.com.au>
Subject: RE: [PATCH v2] gpio: pca953x: add PCAL9535 interrupt support for
 Galileo Gen2

Thanks Linus. I think the below patch(in fixes branch) should be merged into devel branch too, since the below patch is depended by this one in devel branch.

commit 9b8e3ec34318663affced3c14d960e78d760dd9a
Author: Yong Li <sdliyong@...il.com>
Date:   Wed Mar 30 14:49:14 2016 +0800

    gpio: pca953x: Use correct u16 value for register word write

    The current implementation only uses the first byte in val,
    the second byte is always 0. Change it to use cpu_to_le16
    to write the two bytes into the register

    Cc: stable@...r.kernel.org
    Signed-off-by: Yong Li <sdliyong@...il.com>
    Reviewed-by: Phil Reid <preid@...ctromag.com.au>
    Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Yong
> -----Original Message-----
> From: Linus Walleij [mailto:linus.walleij@...aro.org]
> Sent: Friday, April 08, 2016 21:21
> To: Li, Yong B <yong.b.li@...el.com>
> Cc: linux-gpio@...r.kernel.org; linux-kernel@...r.kernel.org; Alexandre
> Courbot <gnurou@...il.com>; Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com>; Puustinen, Ismo
> <ismo.puustinen@...el.com>; Phil Reid <preid@...ctromag.com.au>
> Subject: Re: [PATCH v2] gpio: pca953x: add PCAL9535 interrupt support for
> Galileo Gen2
> 
> n Thu, Apr 7, 2016 at 6:56 AM, Yong Li <yong.b.li@...el.com> wrote:
> 
> > Galileo Gen2 board uses the PCAL9535 as the GPIO expansion, it is
> > different from PCA9535 and includes interrupt mask/status registers,
> > The current driver does not support the interrupt registers
> > configuration, it causes some gpio pins cannot trigger interrupt
> > events, this patch fix this issue. The original patch was submitted by
> > Josef Ahmad <josef.ahmad@...ux.intel.com>
> > http://git.yoctoproject.org/cgit/cgit.cgi/meta-intel-quark/tree/recipe
> > s-kernel/linux/files/0015-Quark-GPIO-1-2-quark.patch
> >
> > Signed-off-by: Yong Li <yong.b.li@...el.com>
> 
> Patch applied with Andy's review tag.
> 
> Yours,
> Linus Walleij