lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 9 Apr 2016 20:21:21 -0700 From: Darren Hart <dvhart@...radead.org> To: Giedrius Statkevičius <giedrius.statkevicius@...il.com> Cc: corentin.chary@...il.com, acpi4asus-user@...ts.sourceforge.net, platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] asus-laptop: remove unused variable On Thu, Apr 07, 2016 at 11:20:01PM +0300, Giedrius Statkevičius wrote: > `out' was assigned value but it was never used so remove it > > Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@...il.com> > --- > drivers/platform/x86/asus-laptop.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c > index d86d42e..39ddcee 100644 > --- a/drivers/platform/x86/asus-laptop.c > +++ b/drivers/platform/x86/asus-laptop.c > @@ -946,11 +946,8 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus, > const char *method) > { > int rv, value; > - int out = 0; > > rv = parse_arg(buf, count, &value); > - if (rv > 0) > - out = value ? 1 : 0; > > if (write_acpi_int(asus->handle, method, value)) out is indeed unused, however the rv > 0 condition is relevant as <=0 will pass value uninitialized to write_acpi_int. -- Darren Hart Intel Open Source Technology Center
Powered by blists - more mailing lists