linux-kernel - Re: [PATCH] staging: wilc1000: rework comments in wilc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 10 Apr 2016 20:44:31 +1000
From:	Julian Calaby <julian.calaby@...il.com>
To:	mohammed.billoo@...il.com
Cc:	Johnny Kim <johnny.kim@...el.com>,
	Austin Shin <austin.shin@...el.com>,
	Chris Park <chris.park@...el.com>,
	Tony Cho <tony.cho@...el.com>, Glen Lee <glen.lee@...el.com>,
	Leo Kim <leo.kim@...el.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: wilc1000: rework comments in wilc_sdio.c

Hi Mohammed,

On Sun, Apr 10, 2016 at 5:11 AM,  <mohammed.billoo@...il.com> wrote:
> From: Mohammed Billoo <mohammed.billoo@...il.com>
>
> Remove unnecessary comments (highlighting sections of functions), make
> multiline comments into single line comments, and ensure that multiline
> comments adhere to coding style.

You need to add a signed-off-by line here.

> ---
>  drivers/staging/wilc1000/wilc_sdio.c | 136 ++++++++---------------------------
>  1 file changed, 31 insertions(+), 105 deletions(-)
>

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/