linux-kernel - Re: [PATCH 2/2] Create sysfs entries for PCI VPDI and VPDR tags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160410212702.GB5852@localhost>
Date:	Sun, 10 Apr 2016 16:27:02 -0500
From:	Bjorn Helgaas <helgaas@...nel.org>
To:	Jordan Hargrave <Jordan_Hargrave@...l.com>
Cc:	bhelgaas@...gle.com, alexander.duyck@...il.com,
	linux-pci@...r.kernel.org, babu.moger@...cle.com, hare@...e.de,
	linux-kernel@...r.kernel.org, jharg93@...il.com
Subject: Re: [PATCH 2/2] Create sysfs entries for PCI VPDI and VPDR tags

On Thu, Feb 18, 2016 at 02:31:04PM -0600, Jordan Hargrave wrote:
> The VPD-R is a readonly area of the PCI Vital Product Data region.
> There are some standard keywords for serial number, manufacturer,
> and vendor-specific values.  Dell Servers use a vendor-specific
> tag to store number of ports and port mapping of partitioned NICs.
> 
> info = VPD-Info string
> PN = Part Number
> SN = Serial Number
> MN = Manufacturer ID
> Vx = Vendor-specific (x=0..9 A..Z)
> 
> This creates a sysfs subdirectory in the pci device: vpdattr with
> 'info', 'EC', 'SN', 'V0', etc. files containing the tag values.
> 
> Added pci.h patch
> 
> Signed-off-by: Jordan Hargrave <Jordan_Hargrave@...l.com>
> ---
>  include/linux/pci.h     |   3 +
>  1 files changed, 3 insertions(+)
> 
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 8135a2f..c1313b1 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -372,6 +372,9 @@ struct pci_dev {
>  	const struct attribute_group **msi_irq_groups;
>  #endif
>  	struct pci_vpd *vpd;
> +	int vpdr_len;
> +	u8 *vpdr_data;
> +	char *vpdi_data;

This should be squashed into the patch that uses the fields you're adding.

>  #ifdef CONFIG_PCI_ATS
>  	union {
>  		struct pci_sriov *sriov;	/* SR-IOV capability related */
> -- 
> 2.5.0
>