| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1460331833-19836-13-git-send-email-greg@chown.ath.cx> Date: Mon, 11 Apr 2016 01:43:52 +0200 From: Grigori Goronzy <greg@...wn.ath.cx> To: Johan Hovold <johan@...nel.org> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, Grigori Goronzy <greg@...wn.ath.cx> Subject: [PATCH v3 12/13] USB: ch341: get rid of default configuration If the serial port hasn't been opened yet, no baud rate should be set and RTS/DTR need to be deasserted. Signed-off-by: Grigori Goronzy <greg@...wn.ath.cx> --- drivers/usb/serial/ch341.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c index 78590b7..451fa64 100644 --- a/drivers/usb/serial/ch341.c +++ b/drivers/usb/serial/ch341.c @@ -24,7 +24,6 @@ #include <linux/serial.h> #include <asm/unaligned.h> -#define DEFAULT_BAUD_RATE 9600 #define DEFAULT_TIMEOUT 1000 /* flags for IO-Bits */ @@ -232,10 +231,6 @@ static int ch341_configure(struct usb_device *dev, struct ch341_private *priv) if (r < 0) goto out; - r = ch341_init_set_baudrate(dev, priv, 0); - if (r < 0) - goto out; - r = ch341_set_handshake(dev, priv->line_control); if (r < 0) goto out; @@ -258,8 +253,6 @@ static int ch341_port_probe(struct usb_serial_port *port) return -ENOMEM; spin_lock_init(&priv->lock); - priv->baud_rate = DEFAULT_BAUD_RATE; - priv->line_control = CH341_BIT_RTS | CH341_BIT_DTR; r = ch341_configure(port->serial->dev, priv); if (r < 0) -- 1.9.1
Powered by blists - more mailing lists