linux-kernel - Re: [PATCH 03/10] mm/hugetlb: Protect follow_huge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <570B3E51.2090308@linux.vnet.ibm.com>
Date:	Mon, 11 Apr 2016 11:34:01 +0530
From:	Anshuman Khandual <khandual@...ux.vnet.ibm.com>
To:	kbuild test robot <lkp@...el.com>
CC:	dave.hansen@...el.com, mgorman@...hsingularity.net,
	hughd@...gle.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	kbuild-all@...org, kirill@...temov.name, n-horiguchi@...jp.nec.com,
	linuxppc-dev@...ts.ozlabs.org, akpm@...ux-foundation.org,
	aneesh.kumar@...ux.vnet.ibm.com
Subject: Re: [PATCH 03/10] mm/hugetlb: Protect follow_huge_(pud|pgd) functions
 from race

On 04/07/2016 03:04 PM, kbuild test robot wrote:
> All errors (new ones prefixed by >>):
> 
>    mm/hugetlb.c: In function 'follow_huge_pud':
>>> >> mm/hugetlb.c:4360:3: error: implicit declaration of function 'pud_page' [-Werror=implicit-function-declaration]
>       page = pud_page(*pud) + ((address & ~PUD_MASK) >> PAGE_SHIFT);
>       ^
>    mm/hugetlb.c:4360:8: warning: assignment makes pointer from integer without a cast
>       page = pud_page(*pud) + ((address & ~PUD_MASK) >> PAGE_SHIFT);
>            ^
>    mm/hugetlb.c: In function 'follow_huge_pgd':
>    mm/hugetlb.c:4395:3: error: implicit declaration of function 'pgd_page' [-Werror=implicit-function-declaration]
>       page = pgd_page(*pgd) + ((address & ~PGDIR_MASK) >> PAGE_SHIFT);

Both the build errors here are because of the fact that pgd_page() is
not available for some platforms and config options. It got missed as
I ran only powerpc config options for build test purpose. My bad, will
fix it.