linux-kernel - Re: [Xen-devel] [PATCH v5 14/14] x86/paravirt: remove paravirt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <570B4961.6000703@suse.com>
Date:	Mon, 11 Apr 2016 08:51:13 +0200
From:	Juergen Gross <jgross@...e.com>
To:	"Luis R. Rodriguez" <mcgrof@...nel.org>, bp@...en8.de,
	hpa@...or.com, tglx@...utronix.de, mingo@...hat.com,
	rusty@...tcorp.com.au
Cc:	kozerkov@...allels.com, matt@...eblueprint.co.uk,
	lv.zheng@...el.com, xen-devel@...ts.xensource.com, joro@...tes.org,
	x86@...nel.org, robert.moore@...el.com, linux-acpi@...r.kernel.org,
	glin@...e.com, lenb@...nel.org, josh@...htriplett.org,
	jlee@...e.com, lguest@...ts.ozlabs.org, boris.ostrovsky@...cle.com,
	andriy.shevchenko@...ux.intel.com, toshi.kani@...com,
	andrew.cooper3@...rix.com, rjw@...ysocki.net,
	linux-kernel@...r.kernel.org, luto@...capital.net,
	david.vrabel@...rix.com, tiwai@...e.de
Subject: Re: [Xen-devel] [PATCH v5 14/14] x86/paravirt: remove
 paravirt_enabled()

On 09/04/16 01:40, Luis R. Rodriguez wrote:
> That that paravirt_enabled() is replaced with proper
> x86 semantics we can remove it.
> 
> Signed-off-by: Luis R. Rodriguez <mcgrof@...nel.org>
> ---
>  arch/x86/include/asm/paravirt.h       | 5 -----
>  arch/x86/include/asm/paravirt_types.h | 1 -
>  arch/x86/include/asm/processor.h      | 1 -
>  arch/x86/kernel/kvm.c                 | 8 --------
>  arch/x86/kernel/paravirt.c            | 1 -
>  arch/x86/lguest/boot.c                | 2 --
>  arch/x86/xen/enlighten.c              | 1 -
>  7 files changed, 19 deletions(-)

Xen parts:

Acked-by: Juergen Gross <jgross@...e.com>


Juergen

> 
> diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h
> index 6c7a4a192032..dff26bc91b17 100644
> --- a/arch/x86/include/asm/paravirt.h
> +++ b/arch/x86/include/asm/paravirt.h
> @@ -15,11 +15,6 @@
>  #include <linux/cpumask.h>
>  #include <asm/frame.h>
>  
> -static inline int paravirt_enabled(void)
> -{
> -	return pv_info.paravirt_enabled;
> -}
> -
>  static inline void load_sp0(struct tss_struct *tss,
>  			     struct thread_struct *thread)
>  {
> diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h
> index 6acc1b26cf40..7fedf24bd811 100644
> --- a/arch/x86/include/asm/paravirt_types.h
> +++ b/arch/x86/include/asm/paravirt_types.h
> @@ -69,7 +69,6 @@ struct pv_info {
>  	u16 extra_user_64bit_cs;  /* __USER_CS if none */
>  #endif
>  
> -	int paravirt_enabled;
>  	const char *name;
>  };
>  
> diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
> index 0c70c7daa6b8..8d326e822cb8 100644
> --- a/arch/x86/include/asm/processor.h
> +++ b/arch/x86/include/asm/processor.h
> @@ -473,7 +473,6 @@ static inline unsigned long current_top_of_stack(void)
>  #include <asm/paravirt.h>
>  #else
>  #define __cpuid			native_cpuid
> -#define paravirt_enabled()	0
>  
>  static inline void load_sp0(struct tss_struct *tss,
>  			    struct thread_struct *thread)
> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
> index dc1207e2f193..eea2a6f72b31 100644
> --- a/arch/x86/kernel/kvm.c
> +++ b/arch/x86/kernel/kvm.c
> @@ -285,14 +285,6 @@ static void __init paravirt_ops_setup(void)
>  {
>  	pv_info.name = "KVM";
>  
> -	/*
> -	 * KVM isn't paravirt in the sense of paravirt_enabled.  A KVM
> -	 * guest kernel works like a bare metal kernel with additional
> -	 * features, and paravirt_enabled is about features that are
> -	 * missing.
> -	 */
> -	pv_info.paravirt_enabled = 0;
> -
>  	if (kvm_para_has_feature(KVM_FEATURE_NOP_IO_DELAY))
>  		pv_cpu_ops.io_delay = kvm_io_delay;
>  
> diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c
> index f08ac28b8136..71a2d8a05a66 100644
> --- a/arch/x86/kernel/paravirt.c
> +++ b/arch/x86/kernel/paravirt.c
> @@ -294,7 +294,6 @@ enum paravirt_lazy_mode paravirt_get_lazy_mode(void)
>  
>  struct pv_info pv_info = {
>  	.name = "bare hardware",
> -	.paravirt_enabled = 0,
>  	.kernel_rpl = 0,
>  	.shared_kernel_pmd = 1,	/* Only used when CONFIG_X86_PAE is set */
>  
> diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c
> index f5497ee5fd2f..3847e736702e 100644
> --- a/arch/x86/lguest/boot.c
> +++ b/arch/x86/lguest/boot.c
> @@ -1408,8 +1408,6 @@ __init void lguest_init(void)
>  {
>  	/* We're under lguest. */
>  	pv_info.name = "lguest";
> -	/* Paravirt is enabled. */
> -	pv_info.paravirt_enabled = 1;
>  	/* We're running at privilege level 1, not 0 as normal. */
>  	pv_info.kernel_rpl = 1;
>  	/* Everyone except Xen runs with this set. */
> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
> index e066fcf87c3d..7c1da39623f4 100644
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
> @@ -1186,7 +1186,6 @@ static unsigned xen_patch(u8 type, u16 clobbers, void *insnbuf,
>  }
>  
>  static const struct pv_info xen_info __initconst = {
> -	.paravirt_enabled = 1,
>  	.shared_kernel_pmd = 0,
>  
>  #ifdef CONFIG_X86_64
>