linux-kernel - Re: [PATCH] ion: scatterlist offset not used for buffer map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160411071010.GA25871@e106921-lin.trondheim.arm.com>
Date:	Mon, 11 Apr 2016 09:10:10 +0200
From:	John Einar Reitan <john.reitan@...s.arm.com>
To:	Colin Cross <ccross@...gle.com>
Cc:	Laura Abbott <labbott@...hat.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ion: scatterlist offset not used for buffer map

> I don't think this is right.  A compound_page still has a page struct
> for every page, you should be passing the page struct where your data
> starts.  Using an offset > PAGE_SIZE is going to break lots of places,
> for example anywhere that uses kmap(sg_page(sg)).

Was kind-of expecting that response. Will update, thanks.