linux-kernel - RE: [patch] iommu/amd: Signedness bug in acpihid_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM3PR1201MB10232C2338DEECF7E74AAAA2E6940@DM3PR1201MB1023.namprd12.prod.outlook.com>
Date:	Mon, 11 Apr 2016 07:22:52 +0000
From:	"Wan, Vincent" <Vincent.Wan@....com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Joerg Roedel <joro@...tes.org>
CC:	"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"Wan Zongshun (vw@...mu.org)" <vw@...mu.org>
Subject: RE: [patch] iommu/amd: Signedness bug in acpihid_device_group()

> From: Dan Carpenter [mailto:dan.carpenter@...cle.com]
> Sent: Monday, April 11, 2016 3:15 PM
> To: Joerg Roedel; Wan, Vincent
> Cc: iommu@...ts.linux-foundation.org; linux-kernel@...r.kernel.org; kernel-
> janitors@...r.kernel.org
> Subject: [patch] iommu/amd: Signedness bug in acpihid_device_group()
> 
> "devid" needs to be signed for the error handling to work.
> 
> Fixes:b097d11a0fa3f ('iommu/amd: Manage iommu_group for ACPI HID
> devices')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index c430c10..12f7779 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -283,7 +283,7 @@ static struct iommu_dev_data *get_dev_data(struct
> device *dev)  static struct iommu_group *acpihid_device_group(struct device
> *dev)  {
>  	struct acpihid_map_entry *p, *entry = NULL;
> -	u16 devid;
> +	int devid;

Sure, thanks for your patch.

Wan Zongshun.

> 
>  	devid = get_acpihid_device_id(dev, &entry);
>  	if (devid < 0)