linux-kernel - Re: [PATCH v1 0/2] x86/init: extend quirk use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <570B52EA.60300@linutronix.de>
Date:	Mon, 11 Apr 2016 09:31:54 +0200
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	"Luis R. Rodriguez" <mcgrof@...nel.org>, bp@...en8.de,
	hpa@...or.com, tglx@...utronix.de, mingo@...hat.com,
	rusty@...tcorp.com.au
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org, luto@...capital.net,
	boris.ostrovsky@...cle.com, david.vrabel@...rix.com,
	konrad.wilk@...cle.com, xen-devel@...ts.xensource.com,
	lguest@...ts.ozlabs.org, andriy.shevchenko@...ux.intel.com,
	jlee@...e.com, glin@...e.com, matt@...eblueprint.co.uk,
	andrew.cooper3@...rix.com, rjw@...ysocki.net, lenb@...nel.org,
	robert.moore@...el.com, lv.zheng@...el.com, toshi.kani@...com,
	linux-acpi@...r.kernel.org, kozerkov@...allels.com,
	josh@...htriplett.org, joro@...tes.org, tiwai@...e.de,
	sathyanarayanan.kuppuswamy@...ux.intel.com, alan@...ux.intel.com,
	rui.zhang@...el.com, mbizon@...ebox.fr, ffainelli@...ebox.fr
Subject: Re: [PATCH v1 0/2] x86/init: extend quirk use

On 04/09/2016 02:22 AM, Luis R. Rodriguez wrote:
> What seems a bit odd is CE4100 leaves RTC enabled, can someone
> confirm if indeed it really needs it, or can it also disable it
> as with Xen, lguest, and Intel MID ?

So what you do with "x86_platform.legacy.rtc" is to skip
add_rtc_cmos(). For ce4100 I added of_have_populated_dt() to skip the
probe.
If you plan to add this to CE4100 you could remove the
"of_have_populated_dt()". It was meant to skip the RTC probe on all OF
platforms but as of now, CE4100 is the only.

Sebastian