linux-kernel - Re: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bn5gpo1v.fsf@intel.com>
Date:	Mon, 11 Apr 2016 11:06:20 +0300
From:	Felipe Balbi <balbi@...nel.org>
To:	changbin.du@...el.com
Cc:	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Du\, Changbin" <changbin.du@...el.com>
Subject: Re: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

changbin.du@...el.com writes:
> From: "Du, Changbin" <changbin.du@...el.com>
>
> dwc->regset is allocated on dwc3_debugfs_init, and should
> be released on dwc3_debugfs_exit.
>
> Signed-off-by: Du, Changbin <changbin.du@...el.com>
> ---
> This patch is seperated from patch set:
>  [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs
> Because it is not related to other 2 patches.
>
> ---
>  drivers/usb/dwc3/debugfs.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
> index 9ac37fe..9eeb444 100644
> --- a/drivers/usb/dwc3/debugfs.c
> +++ b/drivers/usb/dwc3/debugfs.c
> @@ -687,4 +687,7 @@ void dwc3_debugfs_exit(struct dwc3 *dwc)
>  {
>  	debugfs_remove_recursive(dwc->root);
>  	dwc->root = NULL;
> +
> +	kfree(dwc->regset);

we also need a kfree() on dwc3_debugfs_init().

> +	dwc->regset = NULL;

setting regset to NULL is unnecessary. We only call dwc3_debugfs_exit()
when removing the driver.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)