linux-kernel - Re: [PATCH] drivers/usb/gadget/udc/r8a66597-udc.c: Deinline pipe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87vb3oo8kl.fsf@intel.com>
Date:	Mon, 11 Apr 2016 11:26:02 +0300
From:	Felipe Balbi <felipe.balbi@...ux.intel.com>
To:	Denys Vlasenko <dvlasenk@...hat.com>, Felipe Balbi <balbi@...com>
Cc:	Denys Vlasenko <dvlasenk@...hat.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/usb/gadget/udc/r8a66597-udc.c: Deinline pipe_change, save 2176 bytes


Hi again,

Felipe Balbi <felipe.balbi@...ux.intel.com> writes:
> Denys Vlasenko <dvlasenk@...hat.com> writes:
>> This function compiles to 298 bytes of machine code, has ~10 callsites.
>
> fair enough
>
>> This is a USB 2.0 device, USB 2.0 is limited to 35 MB/s, so should be
>
> it's not limited to 35MB/sec, sorry. USB 2.0 has a theoretical maximum
> of 60MB/sec. But 44MB/sec is what people consider 'possible'. I've
> gotten to 41MB/sec with g_mas_storage gadget.

also, you need to break you commit log lines at 72 characters. Please,
fix and resend

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)