[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160411084124.GA11322@intel.com>
Date: Mon, 11 Apr 2016 11:41:24 +0300
From: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To: Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc: tpmdd-devel@...ts.sourceforge.net,
Marcel Selhorst <tpmdd@...horst.net>,
linux-kernel@...r.kernel.org, Peter Huewe <peterhuewe@....de>
Subject: Re: [PATCH] tpm: fix crash in tpm_tis
On Thu, Apr 07, 2016 at 07:36:54AM -0700, Jason Gunthorpe wrote:
> I will have to look closer after the conference, but this does not look
> right.
>
> I vaguely recall commenting on this before. Move the shutdown into the
> core code to fix it.
This fix that I sent is not the right way to do it.
One example scenario:
1. TIS driver gets detached, which causes tpm_tis_remove() to be called.
2. Some in-kernel subsystem uses TPM, which should not be done since the
hardware is already unitialized.
3. The devres subsystem sets ops to NULL.
Even though the fix is wrong I feel that it might put the rwsem into
question.
I'm just thinking that maybe there could be a release callback in
tpm_class_ops that could be called by tpm_del_char_device(). There can't
be clients for the chip at that point so no synchronization mechanism
is needed.
> Jason
/Jarkko
Powered by blists - more mailing lists