linux-kernel - Re: [PATCH V2 17/20] mfd: tps6507x: Use devm_mfd_add_devices() for mfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160411093214.GH7994@x1>
Date:	Mon, 11 Apr 2016 10:32:14 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	corbet@....net, andreas.werner@....de, tony@...mide.com,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, patches@...nsource.wolfsonmicro.com,
	Todd Fischer <todd.fischer@...gerun.com>
Subject: Re: [PATCH V2 17/20] mfd: tps6507x: Use devm_mfd_add_devices() for
 mfd_device registration

Applied, thanks.

On Fri, 08 Apr 2016, Laxman Dewangan wrote:

> Use devm_mfd_add_devices() for MFD devices registration and get
> rid of .remove callback to remove MFD child-devices. This is done
> by managed device framework.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> CC: Todd Fischer <todd.fischer@...gerun.com>
> 
> ---
> Changes from V1:
> - Convert mfd to MFD.
> - Fix checkpatch --strict error on patch.
> 
>  drivers/mfd/tps6507x.c | 13 ++-----------
>  1 file changed, 2 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/mfd/tps6507x.c b/drivers/mfd/tps6507x.c
> index 1ab3dd6..40beb2f 100644
> --- a/drivers/mfd/tps6507x.c
> +++ b/drivers/mfd/tps6507x.c
> @@ -100,16 +100,8 @@ static int tps6507x_i2c_probe(struct i2c_client *i2c,
>  	tps6507x->read_dev = tps6507x_i2c_read_device;
>  	tps6507x->write_dev = tps6507x_i2c_write_device;
>  
> -	return mfd_add_devices(tps6507x->dev, -1, tps6507x_devs,
> -			       ARRAY_SIZE(tps6507x_devs), NULL, 0, NULL);
> -}
> -
> -static int tps6507x_i2c_remove(struct i2c_client *i2c)
> -{
> -	struct tps6507x_dev *tps6507x = i2c_get_clientdata(i2c);
> -
> -	mfd_remove_devices(tps6507x->dev);
> -	return 0;
> +	return devm_mfd_add_devices(tps6507x->dev, -1, tps6507x_devs,
> +				    ARRAY_SIZE(tps6507x_devs), NULL, 0, NULL);
>  }
>  
>  static const struct i2c_device_id tps6507x_i2c_id[] = {
> @@ -132,7 +124,6 @@ static struct i2c_driver tps6507x_i2c_driver = {
>  		   .of_match_table = of_match_ptr(tps6507x_of_match),
>  	},
>  	.probe = tps6507x_i2c_probe,
> -	.remove = tps6507x_i2c_remove,
>  	.id_table = tps6507x_i2c_id,
>  };
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog