linux-kernel - Re: [PATCH 08/10] huge pagecache: extend mremap pmd rmap lockout to files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160411103223.GB22996@node.shutemov.name>
Date:	Mon, 11 Apr 2016 13:32:23 +0300
From:	"Kirill A. Shutemov" <kirill@...temov.name>
To:	Hugh Dickins <hughd@...gle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Andres Lagar-Cavilla <andreslc@...gle.com>,
	Yang Shi <yang.shi@...aro.org>, Ning Qu <quning@...il.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 08/10] huge pagecache: extend mremap pmd rmap lockout to
 files

On Tue, Apr 05, 2016 at 01:52:48PM -0700, Hugh Dickins wrote:
> Whatever huge pagecache implementation we go with, file rmap locking
> must be added to anon rmap locking, when mremap's move_page_tables()
> finds a pmd_trans_huge pmd entry: a simple change, let's do it now.
> 
> Factor out take_rmap_locks() and drop_rmap_locks() to handle the
> locking for make move_ptes() and move_page_tables(), and delete
> the VM_BUG_ON_VMA which rejected vm_file and required anon_vma.
> 
> Signed-off-by: Hugh Dickins <hughd@...gle.com>

Yeah, it's cleaner than my variant.

Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

-- 
 Kirill A. Shutemov