linux-kernel - [RESEND] block: swim3: Fix module autoload for OF platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 11 Apr 2016 11:53:33 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	david@...son.dropbear.id.au
Cc:	linux-kernel@...r.kernel.org, benh@...nel.crashing.org,
	akpm@...ux-foundation.org, gregkh@...uxfoundation.org,
	Luis de Bethencourt <luisbg@....samsung.com>
Subject: [RESEND] block: swim3: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>

---
Hi,

This is a resend of a patch from September 15th and November 12th [0]

Adding Andrew Morton and Greg KH to the CC list, as recommended at Linux
Korea Forum.

This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
that information so modules have the correct aliases built-in and
autoloading works correctly.

A longer explanation by Javier Canillas can be found here:
https://lkml.org/lkml/2015/7/30/519
A multitude of similar patches have been merged for other drivers, search
the git log for "module autoload for OF platform driver".

Thanks,
Luis

[0] https://lkml.org/lkml/2015/9/15/757

 drivers/block/swim3.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
index c264f2d..d6ebf17 100644
--- a/drivers/block/swim3.c
+++ b/drivers/block/swim3.c
@@ -1258,6 +1258,7 @@ static struct of_device_id swim3_match[] =
 	},
 	{ /* end of list */ }
 };
+MODULE_DEVICE_TABLE(of, swim3_match);

 static struct macio_driver swim3_driver =
 {