linux-kernel - RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87shyso0tp.fsf@intel.com>
Date:	Mon, 11 Apr 2016 14:13:22 +0300
From:	Felipe Balbi <balbi@...nel.org>
To:	"Du\, Changbin" <changbin.du@...el.com>
Cc:	"gregkh\@linuxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb\@vger.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

"Du, Changbin" <changbin.du@...el.com> writes:

>> > diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
>> > index 9ac37fe..9eeb444 100644
>> > --- a/drivers/usb/dwc3/debugfs.c
>> > +++ b/drivers/usb/dwc3/debugfs.c
>> > @@ -687,4 +687,7 @@ void dwc3_debugfs_exit(struct dwc3 *dwc)
>> >  {
>> >  	debugfs_remove_recursive(dwc->root);
>> >  	dwc->root = NULL;
>> > +
>> > +	kfree(dwc->regset);
>> 
>> we also need a kfree() on dwc3_debugfs_init().
> This patch is based on the patch set 
> [PATCH v3 1/2] usb: dwc3: make dwc3_debugfs_init return value be void> 
> So, they do has dependency. :)

I _did_ mention on previous set that fixes and new-features shouldn't
have dependencies between them. That was the whole point of splitting
the series in two.

>> > +	dwc->regset = NULL;
>> 
>> setting regset to NULL is unnecessary. We only call dwc3_debugfs_exit()
>> when removing the driver.
>> 
>> --
>> Balbi
> I'd like keep this line even it is unnecessary, because It is a good habit to
> Avoid wild pointers. Just like the dwc->root = NULL.

there won't be any wild pointers here, we'll free struct dwc3 *dwc itself.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)