| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <ab42fc31ba4ca83232aa2bfeab5f9f51312c65cb.1460380917.git.jslaby@suse.cz> Date: Mon, 11 Apr 2016 15:23:28 +0200 From: Jiri Slaby <jslaby@...e.cz> To: stable@...r.kernel.org Cc: linux-kernel@...r.kernel.org, "Steven Rostedt (Red Hat)" <rostedt@...dmis.org>, Jiri Slaby <jslaby@...e.cz> Subject: [PATCH 3.12 86/98] tracing: Fix crash from reading trace_pipe with sendfile From: "Steven Rostedt (Red Hat)" <rostedt@...dmis.org> 3.12-stable review patch. If anyone has any objections, please let me know. =============== commit a29054d9478d0435ab01b7544da4f674ab13f533 upstream. If tracing contains data and the trace_pipe file is read with sendfile(), then it can trigger a NULL pointer dereference and various BUG_ON within the VM code. There's a patch to fix this in the splice_to_pipe() code, but it's also a good idea to not let that happen from trace_pipe either. Link: http://lkml.kernel.org/r/1457641146-9068-1-git-send-email-rabin@rab.in Reported-by: Rabin Vincent <rabin.vincent@...il.com> Signed-off-by: Steven Rostedt <rostedt@...dmis.org> Signed-off-by: Jiri Slaby <jslaby@...e.cz> --- kernel/trace/trace.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 1b51436db225..12cff54899ee 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -4362,7 +4362,10 @@ static ssize_t tracing_splice_read_pipe(struct file *filp, spd.nr_pages = i; - ret = splice_to_pipe(pipe, &spd); + if (i) + ret = splice_to_pipe(pipe, &spd); + else + ret = 0; out: splice_shrink_spd(&spd); return ret; -- 2.8.1
Powered by blists - more mailing lists