linux-kernel - [PATCH 3.12 74/98] bcache: fix cache_set_flush() NULL pointer dereference on OOM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <e825d104aedb528fcf11781ec2e343d1ce4d8ca1.1460380917.git.jslaby@suse.cz>
Date:	Mon, 11 Apr 2016 15:23:16 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	stable@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org,
	Eric Wheeler <git@...ux.ewheeler.net>,
	Eric Wheeler <bcache@...ux.ewheeler.net>,
	Jiri Slaby <jslaby@...e.cz>
Subject: [PATCH 3.12 74/98] bcache: fix cache_set_flush() NULL pointer dereference on OOM

From: Eric Wheeler <git@...ux.ewheeler.net>

3.12-stable review patch.  If anyone has any objections, please let me know.

===============

commit f8b11260a445169989d01df75d35af0f56178f95 upstream.

When bch_cache_set_alloc() fails to kzalloc the cache_set, the
asyncronous closure handling tries to dereference a cache_set that
hadn't yet been allocated inside of cache_set_flush() which is called
by __cache_set_unregister() during cleanup.  This appears to happen only
during an OOM condition on bcache_register.

Signed-off-by: Eric Wheeler <bcache@...ux.ewheeler.net>
Signed-off-by: Jiri Slaby <jslaby@...e.cz>
---
 drivers/md/bcache/super.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 70d396ee69e2..2a697b3d58c5 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1343,6 +1343,9 @@ static void cache_set_flush(struct closure *cl)
 	struct btree *b;
 	unsigned i;
 
+	if (!c)
+		closure_return(cl);
+
 	bch_cache_accounting_destroy(&c->accounting);
 
 	kobject_put(&c->internal);
-- 
2.8.1