linux-kernel - Re: [RFT v2] iommu/amd: use subsys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFCwf10oD9c3MOW3+J8A5MVjVkX0nNRGCEE2pWcQxOy7mjUsBw@mail.gmail.com>
Date:	Mon, 11 Apr 2016 16:39:43 +0300
From:	Oded Gabbay <oded.gabbay@...il.com>
To:	Christian König <christian.koenig@....com>
Cc:	"Luis R. Rodriguez" <mcgrof@...nel.org>,
	Joerg Roedel <joro@...tes.org>,
	iommu@...ts.linux-foundation.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

On Mon, Apr 11, 2016 at 4:28 PM, Christian König
<christian.koenig@....com> wrote:
>
> Am 09.04.2016 um 02:25 schrieb Luis R. Rodriguez:
>>
>> On Tue, Mar 29, 2016 at 10:41 AM, Luis R. Rodriguez <mcgrof@...nel.org> wrote:
>>>
>>> We need to ensure amd iommu v2 initializes before
>>> driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c,
>>> to do this make its init routine a subsys_initcall() which
>>> ensures its load init is called first than modules when
>>> built-in.
>>>
>>> This reverts the old work around implemented through commit
>>> 1bacc894c227fad8a7 ("drivers: Move iommu/ before gpu/ in Makefile"),
>>> instead of making the dependency implicit by linker order this
>>> makes the ordering requirement explicit through proper kernel
>>> APIs.
>>>
>>> Cc: Oded Gabbay <oded.gabbay@....com>
>>> Cc: Christian König <christian.koenig@....com>
>>> Signed-off-by: Luis R. Rodriguez <mcgrof@...nel.org>
>
>
> Sorry for not responding earlier. Just coming back to all the stuff on my TODO list.
>
> Patch is Acked-by: Christian König <christian.koenig@....com>


Christian,
Just wanted to be sure if you tested this patch-set or not.

I don't think it should be merged without testing. If you already
tested it than fine. If not, I think I can do it in the next week or
so (just came back from PTO).

Oded

>
>
> Regards,
> Christian.
>
>> *poke*
>>
>>   Luis
>
>