linux-kernel - Re: [PART1 RFC v4 09/11] svm: Do not expose x2APIC when enable AVIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160411205423.GA29328@potion.brq.redhat.com>
Date:	Mon, 11 Apr 2016 22:54:24 +0200
From:	Radim Krčmář <rkrcmar@...hat.com>
To:	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
Cc:	pbonzini@...hat.com, joro@...tes.org, bp@...en8.de,
	gleb@...nel.org, alex.williamson@...hat.com, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org, wei@...hat.com,
	sherry.hurwitz@....com
Subject: Re: [PART1 RFC v4 09/11] svm: Do not expose x2APIC when enable AVIC

2016-04-07 03:20-0500, Suravee Suthikulpanit:
> From: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
> 
> Since AVIC only virtualizes xAPIC hardware for the guest, this patch
> disable x2APIC support in guest CPUID.
> 
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
> ---
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> @@ -4560,14 +4560,26 @@ static u64 svm_get_mt_mask(struct kvm_vcpu *vcpu, gfn_t gfn, bool is_mmio)
>  static void svm_cpuid_update(struct kvm_vcpu *vcpu)
>  {
>  	struct vcpu_svm *svm = to_svm(vcpu);
> +	struct kvm_cpuid_entry2 *entry;
>  
>  	/* Update nrips enabled cache */
>  	svm->nrips_enabled = !!guest_cpuid_has_nrips(&svm->vcpu);
> +
> +	if (!svm_vcpu_avic_enabled(svm))
> +		return;
> +
> +	entry = kvm_find_cpuid_entry(vcpu, 0x1, 0);
> +	if (entry->function == 1)

entry->function == 1 will always be true, because entry can be NULL
otherwise, so we would bug before.  Check for entry.

> +		entry->ecx &= ~bit(X86_FEATURE_X2APIC);
>  }
>  
>  static void svm_set_supported_cpuid(u32 func, struct kvm_cpuid_entry2 *entry)
>  {
>  	switch (func) {
> +	case 0x00000001:

("case 1:" or "case 0x1:" would be easier to read.)

> +		if (avic)
> +			entry->ecx &= ~bit(X86_FEATURE_X2APIC);
> +		break;


---
A rant for the unlikely case I get back to fix the broader situation:
Only one of these two additions is needed.  If we do the second one,
then userspace should not set X2APIC, therefore the first one is
useless.

Omitting the second one allows userspace to clear apicv_active and set
X86_FEATURE_X2APIC, but it needs a non-intuitive order of ioctls, so I
think we should have the second one.

The problem is that KVM doesn't seems to check whether userspace sets
cpuid that is a subset of supported ones, so omitting the first one
needlessly expands the space for potential failures.