linux-kernel - Re: [PATCH v3] extcon: usb-gpio: Don't miss event during suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <570C287A.8040002@samsung.com>
Date:	Tue, 12 Apr 2016 07:43:06 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Roger Quadros <rogerq@...com>, myungjoo.ham@...sung.com
Cc:	linux-kernel@...r.kernel.org,
	Grygorii Strashko <grygorii.strashko@...com>
Subject: Re: [PATCH v3] extcon: usb-gpio: Don't miss event during suspend/resume

Hi Roger,

On 2016년 04월 11일 23:04, Roger Quadros wrote:
> Pin state might have changed during suspend/resume while
> our interrupts were disabled and if device doesn't support wakeup.
> 
> Scan for change during resume for such case.
> 
> Signed-off-by: Roger Quadros <rogerq@...com>
> ---
> v3:
> - use queue_delayed_work() instead of directly calling usb_extcon_detect_cable()
> 
> v2:
> - only check for state change during resume if device wakeup is 
> 
>  drivers/extcon/extcon-usb-gpio.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index bc61d11..bad2159 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -185,6 +185,9 @@ static int usb_extcon_resume(struct device *dev)
>  	int ret = 0;
>  
>  	enable_irq(info->id_irq);
> +	if (!device_may_wakeup(dev))
> +		queue_delayed_work(system_power_efficient_wq,
> +				   &info->wq_detcable, 0);
>  
>  	return ret;
>  }
> 

Applied it.

Thanks,
Chanwoo Choi